Skip to content

S3 backend: include path prefix in removal requests.#673

Merged
smira merged 1 commit intoaptly-dev:masterfrom
AgNO3:s3-removal
Nov 19, 2017
Merged

S3 backend: include path prefix in removal requests.#673
smira merged 1 commit intoaptly-dev:masterfrom
AgNO3:s3-removal

Conversation

@mbechler
Copy link
Contributor

DELETE requests, both for temporary files and no longer referenced
packages, lacked the configured path prefix and therefor were not
removed if a prefix is configured.

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Adds the path prefix to Remove() so that temporary and unreferenced pool files are properly removed.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

DELETE requests, both for temporary files and no longer referenced
packages, lacked the configured path prefix and therefor were not
removed if a prefix is configured.
Copy link
Contributor

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@smira smira merged commit 14d4a27 into aptly-dev:master Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants