Merged
Conversation
This was done to fix a problem for a package with a really long list of dependencies. It would be nice if this kind of values are configurable via a config for future, to avoid editing the code for custom use cases. thanks to Sorin Pop, who found and fixed the issue in our internal system :)
fix big list of dependency problems (up to 2MB)
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
==========================================
+ Coverage 59.17% 59.19% +0.01%
==========================================
Files 50 50
Lines 6183 6185 +2
==========================================
+ Hits 3659 3661 +2
Misses 2123 2123
Partials 401 401
Continue to review full report at Codecov.
|
This way `bufio.Scanner` would allocate initial buffer of default size, buf might still grow to maximum defined size.
Contributor
|
@strajansebastian thanks for the PR, I have added some changes and unit-tests (I borrowed your sample file), please let me know if that looks good to you |
Contributor
Author
|
@smira everything looks good from my point of view. Thanks for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase buffer size for dependency list to up to 2MB of package names.
Fixes #
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
Checklist
AUTHORS