Add week timeframe to Polish locale#769
Merged
systemcatch merged 4 commits intoarrow-py:masterfrom Apr 7, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1696 1681 -15
Branches 288 288
=========================================
- Hits 1696 1681 -15
Continue to review full report at Codecov.
|
jadchaar
approved these changes
Apr 6, 2020
Member
jadchaar
left a comment
jadchaar
left a comment
There was a problem hiding this comment.
Looks good thanks for the contribution @akwodkiewicz!
Member
|
Hey @akwodkiewicz, seems like a recent merge that contained some big changes to our testing suite was merged in and thus caused some conflicts. Mind resolving them so we can merge this in? |
Collaborator
|
Conflicts don't look to bad, I can help with fixing if need be. |
systemcatch
approved these changes
Apr 7, 2020
Contributor
Author
|
Thanks @systemcatch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).(:x: No documentation change needed.)
masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
I've added missing
weekandweekstimeframes to Polish locale and also fixed the grammar errors in the existing entries.