Skip to content

Comments

fix: mislabeled scripts and writing strings versus bytes#759

Merged
s3rvac merged 1 commit intoavast:masterfrom
kayarre:python_scripts
May 3, 2020
Merged

fix: mislabeled scripts and writing strings versus bytes#759
s3rvac merged 1 commit intoavast:masterfrom
kayarre:python_scripts

Conversation

@kayarre
Copy link

@kayarre kayarre commented May 1, 2020

python script issues:

if self.decompiler_args, is empty its a string "" and can't be concatenated

"wb" fails for unencoded strings for the log files. changed to "w"

script names don't match causing failures.

@s3rvac s3rvac self-assigned this May 3, 2020
@s3rvac s3rvac self-requested a review May 3, 2020 08:04
Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes 👍 All three of them are correct.

@s3rvac s3rvac merged commit 46b13c1 into avast:master May 3, 2020
s3rvac added a commit that referenced this pull request May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants