Merged
Conversation
BitArts is the name of the company that produced Crunch packer. Everything detected by this YARA rule was also detected by the appropriate Crunch YARA rule. As such, one of them should be removed.
Member
|
Thank you for the improvements! Let's run TeamCity tests. |
s3rvac
approved these changes
Jul 22, 2020
Member
s3rvac
left a comment
There was a problem hiding this comment.
TeamCity builds are failing because there have been new changes in the loader that have not been incorporated into the branch in the present PR (and in tests). However, I have run the tests on my Linux machine on up-to-date branches, and they have passed. So, I am approving and merging the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
BitArtspacker. It is covered by the detections ofCrunch(BitArtsis a company that producedCrunchpacker).MoleBoxvirtualizer/packer.MoleBox v4.2321MoleBox v2.3.6The tests are added here.