Fix crash on samples having corrupted PE header (#821)#827
Merged
Conversation
s3rvac
reviewed
Jul 29, 2020
Member
s3rvac
left a comment
s3rvac
left a comment
There was a problem hiding this comment.
Thank you for the fix. I will run tests, just to be sure that everything builds and there is no unintentional side effect.
If a sample has corrupted PE header and as a result does not have any sections, heuristic search for UPX packer will fail as it tries to access the first section. To remedy this, we need to ensure the sections exist before we access them.
tamaroth
force-pushed
the
bug-upx-crash-821
branch
from
dd33aab to
b35bf1c
Compare
s3rvac
changed the title
s3rvac
approved these changes
Jul 29, 2020
Member
s3rvac
left a comment
s3rvac
left a comment
There was a problem hiding this comment.
LGTM. Tests are passing, so I am going to merge the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a sample has corrupted PE header and as a result does not have any
sections, heuristic search for UPX packer will fail as it tries to
access the first section. To remedy this, we need to ensure the sections
exist before we access them.
Issue #821
Test added here