Small improvements to detections of binary tools.#831
Merged
Conversation
That specific YARA rule detects a generic EntryPoint code generated by old MSVC compilers.
Gentee is a programming language that uses its own byte code withing a static binary shell. All samples containing the '.gentee' sections are usually just compiled Gentee binaries and not packed by Gentee (which is a misnomer).
s3rvac
approved these changes
Jul 31, 2020
Member
s3rvac
left a comment
s3rvac
left a comment
There was a problem hiding this comment.
Thank you for the improvements 👍 I see no issues with the changes and all builds and tests pass, so I am going to merge the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes:
InstallShieldhas been removed. Many files that were detected were not InstallShield files but contained a generic entry point code.installertocompiler.This PR does not come with an attached bug report or with tests. However, if need be I can provide a single test for the Gentee change.