unpacker/mpress: Properly copy non-packer related sections to the unpacked file#913
Merged
unpacker/mpress: Properly copy non-packer related sections to the unpacked file#913
Conversation
Member
Author
|
Lets run TC tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the commit 60ea783, we've had MPRESS unpacker bugged. Specifically the part which copied sections from packed PE into unpacked PE, which were not modified by packing process at all. This resulted in files unpacked by our
retdec-unpackerto miss things like exports, resources and other things which are usually placed in their own sections (apart from imports which were properly reconstructed and unpacked code).