Skip to content

webui: fix a layout corner case where top navbar is hiding navtabs#1022

Merged
pstorz merged 2 commits intomasterfrom
dev/fbergkemper/master/layout-fix
Dec 13, 2021
Merged

webui: fix a layout corner case where top navbar is hiding navtabs#1022
pstorz merged 2 commits intomasterfrom
dev/fbergkemper/master/layout-fix

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Dec 10, 2021

At a certain display width the top navigation bar can overlap
navigation tabs below, this commit fixes the issue by adjusting
padding-top slightly.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

@frb121 frb121 self-assigned this Dec 10, 2021
@frb121 frb121 requested a review from pstorz December 10, 2021 14:20
@frb121 frb121 force-pushed the dev/fbergkemper/master/layout-fix branch from 391dd44 to 3f7af02 Compare December 10, 2021 14:43
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR Title is too general, this can mean anything. It would make sense to describe what corner case is fixed.

E.g. Fix layout corner case wherer submenu is hidden under second line of main menu when main menu is wrapped.

@frb121 frb121 force-pushed the dev/fbergkemper/master/layout-fix branch from 3f7af02 to b1871f0 Compare December 13, 2021 09:49
@frb121 frb121 changed the title webui: fix a layout corner case issue webui: fix a layout corner case where top navbar is hiding below navtabs Dec 13, 2021
@frb121
Copy link
Contributor Author

frb121 commented Dec 13, 2021

The PR Title is too general, this can mean anything. It would make sense to describe what corner case is fixed.

E.g. Fix layout corner case wherer submenu is hidden under second line of main menu when main menu is wrapped.

I've adjusted the PR title to be more precise.

@frb121 frb121 requested a review from pstorz December 13, 2021 09:52
@frb121 frb121 changed the title webui: fix a layout corner case where top navbar is hiding below navtabs webui: fix a layout corner case where top navbar is hiding navtabs Dec 13, 2021
At a certain display width the top navigation bar can overlap and hide
navigation tabs below, this commit fixes the issue by adjusting
padding-top slightly.
@frb121 frb121 force-pushed the dev/fbergkemper/master/layout-fix branch from b1871f0 to 91ce2b1 Compare December 13, 2021 10:41
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@pstorz pstorz merged commit 2064d78 into master Dec 13, 2021
@pstorz pstorz deleted the dev/fbergkemper/master/layout-fix branch December 13, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments