webui: fix a layout corner case where top navbar is hiding navtabs#1022
Merged
webui: fix a layout corner case where top navbar is hiding navtabs#1022
Conversation
391dd44 to
3f7af02
Compare
pstorz
requested changes
Dec 13, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
The PR Title is too general, this can mean anything. It would make sense to describe what corner case is fixed.
E.g. Fix layout corner case wherer submenu is hidden under second line of main menu when main menu is wrapped.
3f7af02 to
b1871f0
Compare
Contributor
Author
I've adjusted the PR title to be more precise. |
At a certain display width the top navigation bar can overlap and hide navigation tabs below, this commit fixes the issue by adjusting padding-top slightly.
b1871f0 to
91ce2b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a certain display width the top navigation bar can overlap
navigation tabs below, this commit fixes the issue by adjusting
padding-top slightly.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests