cats:lib: removed comma formatting from jobId attribute in list jobs output.

[HediBenFraj]

Description

List jobs shows jobId with comma formatting.
This PR fixes the issue by removing the commas from jobid attribute in the command output".

Please check

• Short description and the purpose of this PR is present above this paragraph
• Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

• Git Workflow
• Automatic Sourcecode Formatting
• Check your commit messages

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

• PR name is meaningful
• Purpose of the PR is understood
• Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
• Commit descriptions are understandable and well formatted
• If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x

Source code quality

• Source code changes are understandable
• Variable and function names are meaningful
• Code comments are correct (logically and spelling)
• Required documentation changes are present and part of the PR
• bareos-check-sources --since-merge does not report any problems
• git status should not report modifications in the source tree after building and testing

Tests

• Decision taken that a system- or unittest is required (if not, then remove this paragraph)
• The decision towards a systemtest is reasonable compared to a unittest
• Testname matches exactly what is being tested
• Output of the test leads quickly to the origin of the fault

[bruno-at-bareos]

Just a question, but in our backlog, from what I read : the initial idea was to be able to copy and paste jobids so I don't see a point to replace comma by space ?

[HediBenFraj]

Just a question, but in our backlog, from what I read : the initial idea was to be able to copy and paste jobids so I don't see a point to replace comma by space ?

yes it was suggested to remove the commas: they make it hard to copy and paste jobIds to use them in other commands (will require to manually remove the commas, I think )
we can also remove the separation altogether if necessary.

[HediBenFraj]

@arogge By the way didn't need the trim method.
also i had to use the

if (jobid){
// do_not_add_commas
}else{
// add_commas
}

[arogge]

I noticed a formatting issue with the table. It looks like the calculation for the width of the column still calculates it as if the commas were still these.
Note the excess spaces in this example:

+------------+------------------+-----------+---------------------+----------+------+-------+----------+----------+-----------+
| jobid      | name             | client    | starttime           | duration | type | level | jobfiles | jobbytes | jobstatus |
+------------+------------------+-----------+---------------------+----------+------+-------+----------+----------+-----------+
|   10000000 | backup-bareos-fd | bareos-fd | 2022-03-28 11:46:48 | 00:00:01 | B    | F     |       73 |  144,145 | T         |

Other than that we may want to not add commas to priorjobid as that will also contain a jobid value. (AFAIR only llist job displays that field)

[arogge]

that doesn't describe the change correctly anymore

[arogge]

the file's header doesn't have the right copyright years set.

[arogge]

as there's no other change in this file, we should also not change the header.