Skip to content

dird: fix config reload and unit tests dependency issue#1161

Merged
pstorz merged 6 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-config-reload-test-dependency-issue
Sep 7, 2022
Merged

dird: fix config reload and unit tests dependency issue#1161
pstorz merged 6 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-config-reload-test-dependency-issue

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Apr 12, 2022

Description

When creating google tests that include ua_cmd, a dependency issue arises around the DoReloadConfig() function and forces developers to re-implement it within the test to return a random false. This PR fixes the issue.

Waiting on PR #1151 , and then need to be redone

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@alaaeddineelamri alaaeddineelamri self-assigned this Apr 12, 2022
@pstorz pstorz added the onhold label Apr 21, 2022
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-config-reload-test-dependency-issue branch from 95a401a to cc7d9d1 Compare April 26, 2022 09:25
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-config-reload-test-dependency-issue branch from cc7d9d1 to 25bb32c Compare August 11, 2022 10:37
@alaaeddineelamri alaaeddineelamri marked this pull request as draft August 11, 2022 12:04
@alaaeddineelamri alaaeddineelamri marked this pull request as ready for review August 11, 2022 12:04
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-config-reload-test-dependency-issue branch 4 times, most recently from 4004026 to 41ca489 Compare August 16, 2022 14:23
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-config-reload-test-dependency-issue branch 3 times, most recently from fcd36cc to c1c7083 Compare August 23, 2022 14:30
@bruno-at-bareos bruno-at-bareos requested a review from pstorz August 25, 2022 10:14
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extrating the IsSameStorageDaemon() would be great.
Other than that: Good work!

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-config-reload-test-dependency-issue branch 5 times, most recently from 6528455 to 0c2ce57 Compare September 5, 2022 09:09
@pstorz pstorz force-pushed the dev/alaaeddineelamri/master/fix-config-reload-test-dependency-issue branch from fdded92 to bcf5af2 Compare September 7, 2022 14:50
@pstorz pstorz self-requested a review September 7, 2022 14:52
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. As soon as it successfully builds we can merge.

Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz force-pushed the dev/alaaeddineelamri/master/fix-config-reload-test-dependency-issue branch from b539d28 to 2b7cfc2 Compare September 7, 2022 14:57
@pstorz pstorz merged commit fbd0989 into bareos:master Sep 7, 2022
@pstorz pstorz deleted the dev/alaaeddineelamri/master/fix-config-reload-test-dependency-issue branch September 7, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments