dird: fix config reload and unit tests dependency issue#1161
Merged
pstorz merged 6 commits intobareos:masterfrom Sep 7, 2022
Conversation
95a401a to
cc7d9d1
Compare
cc7d9d1 to
25bb32c
Compare
4004026 to
41ca489
Compare
fcd36cc to
c1c7083
Compare
pstorz
requested changes
Aug 29, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Extrating the IsSameStorageDaemon() would be great.
Other than that: Good work!
6528455 to
0c2ce57
Compare
fdded92 to
bcf5af2
Compare
pstorz
approved these changes
Sep 7, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work. As soon as it successfully builds we can merge.
b539d28 to
2b7cfc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When creating google tests that include
ua_cmd, a dependency issue arises around theDoReloadConfig()function and forces developers to re-implement it within the test to return a randomfalse. This PR fixes the issue.Waiting on PR #1151 , and then need to be redone
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing