Skip to content

packaging: FreeBSD improve packaging by installing scripts into /usr/local/lib/bareos#1163

Merged
pstorz merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/t5115-FreeBSD_improve_packaging
Apr 26, 2022
Merged

packaging: FreeBSD improve packaging by installing scripts into /usr/local/lib/bareos#1163
pstorz merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/t5115-FreeBSD_improve_packaging

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Apr 19, 2022

This PR improve FreeBSD packaging by placing all script into /usr/local/lib/bareos by unifying -dScriptdir cmake variable
and using relative path for pkg location.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@bruno-at-bareos bruno-at-bareos requested a review from pstorz April 19, 2022 14:01
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/t5115-FreeBSD_improve_packaging branch from 7e02c58 to 1c5dd9e Compare April 21, 2022 07:45
@bruno-at-bareos
Copy link
Contributor Author

this need to adapt also ci-script (see branch pr-1163)

…l/lib).

- Install our scripts to the standard location /usr/local/lib instead
  of /usr/lib for FreeBSD.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/t5115-FreeBSD_improve_packaging branch from 1c5dd9e to a5f1c1a Compare April 25, 2022 09:55
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If passes build we can merge it.

@pstorz pstorz merged commit 1f360a3 into bareos:master Apr 26, 2022
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/t5115-FreeBSD_improve_packaging branch July 4, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments