Skip to content

Add support for Ubuntu 22.04, Fedora 36, EL 9, openSUSE 15.4#1179

Merged
pstorz merged 26 commits intomasterfrom
dev/pstorz/master/ubuntu22
Jun 22, 2022
Merged

Add support for Ubuntu 22.04, Fedora 36, EL 9, openSUSE 15.4#1179
pstorz merged 26 commits intomasterfrom
dev/pstorz/master/ubuntu22

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented May 11, 2022

This PR enables building for Ubuntu 22.04, Fedora 36, EL 9, openSUSE 15.4.
Removing support for obsolete openSUSE 15.2 and Fedora 34.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Tests are runs on new platform

@pstorz pstorz force-pushed the dev/pstorz/master/ubuntu22 branch from 5351800 to d37767f Compare May 19, 2022 08:38
@pstorz pstorz self-assigned this May 19, 2022
@pstorz pstorz changed the title Add support for Ubuntu 22.04 Add support for Ubuntu 22.04, Fedora 36, EL 9 May 20, 2022
@pstorz pstorz force-pushed the dev/pstorz/master/ubuntu22 branch from 530b10b to b9efb7c Compare May 20, 2022 12:27
@pstorz pstorz force-pushed the dev/pstorz/master/ubuntu22 branch 2 times, most recently from d257c90 to 5dec061 Compare June 14, 2022 09:44
@pstorz pstorz changed the title Add support for Ubuntu 22.04, Fedora 36, EL 9 Add support for Ubuntu 22.04, Fedora 36, EL 9, openSUSE 15.4 Jun 15, 2022
@bruno-at-bareos bruno-at-bareos self-requested a review June 15, 2022 09:43
@pstorz pstorz force-pushed the dev/pstorz/master/ubuntu22 branch from 4c02cc5 to 4beec5e Compare June 17, 2022 11:36
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly okay, see proposal for the suse gcc block in spec.

@bruno-at-bareos
Copy link
Contributor

bruno-at-bareos commented Jun 22, 2022

During the review, the check-sources return modification on

Plugin 'fix copyright year' would modify 'core/cmake/BareosFindAllLibraries.cmake'
Plugin 'fix copyright year' would modify 'core/src/droplet/libdroplet/CMakeLists.txt'
Plugin 'clang-format check' would modify 'core/src/droplet/libdroplet/include/droplet/cdmi/crcmodel.h'
Plugin 'cmake format' would modify 'core/src/lib/CMakeLists.txt'

Once it build again and goes green, it will be time to bundle the commit, and add a changelog line.

@pstorz pstorz force-pushed the dev/pstorz/master/ubuntu22 branch from a36d35b to 0664889 Compare June 22, 2022 09:45
@bruno-at-bareos bruno-at-bareos force-pushed the dev/pstorz/master/ubuntu22 branch from 0664889 to 6b33d61 Compare June 22, 2022 12:25
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After last green, the PR is ready to be merged. Thanks for the work.

@pstorz pstorz merged commit 863e9f4 into master Jun 22, 2022
@pstorz pstorz deleted the dev/pstorz/master/ubuntu22 branch June 22, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments