Skip to content

testfind: reuse filedaemon logic#1234

Merged
arogge merged 34 commits intobareos:masterfrom
HediBenFraj:dev/HediBenFraj/build-testfind/add-readFile-feature-to-testfind
Mar 2, 2023
Merged

testfind: reuse filedaemon logic#1234
arogge merged 34 commits intobareos:masterfrom
HediBenFraj:dev/HediBenFraj/build-testfind/add-readFile-feature-to-testfind

Conversation

@HediBenFraj
Copy link
Contributor

@HediBenFraj HediBenFraj commented Aug 23, 2022 •
edited by sebsura
Loading

Description

In this PR, testfind tries first to mimic sending filesets from DIR to FD, and then tries to mimic sending over files from the FD to the SD, without the SD receiving any actual data.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/build-testfind/add-readFile-feature-to-testfind branch 2 times, most recently from 6d96b52 to 154669e Compare August 23, 2022 10:04
pstorz
pstorz previously requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not implement what it says that it does.

What are the steps to read data from a file?

@HediBenFraj HediBenFraj changed the title Dev/hedi ben fraj/build testfind/add read file feature to testfind testfind: added read file functionality Aug 25, 2022
@HediBenFraj
Copy link
Contributor Author

HediBenFraj commented Aug 25, 2022 •
edited
Loading

This PR does not implement what it says that it does.

What are the steps to read data from a file?

the actual reading of the file is missing I am working on it

@HediBenFraj HediBenFraj reopened this Aug 25, 2022
@pstorz pstorz force-pushed the dev/HediBenFraj/build-testfind/add-readFile-feature-to-testfind branch from 154669e to ec40a6d Compare August 26, 2022 10:26
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/build-testfind/add-readFile-feature-to-testfind branch from ec40a6d to 3e35d03 Compare August 26, 2022 11:22
@pstorz pstorz changed the title testfind: added read file functionality testfind: add read file functionality Aug 29, 2022
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/build-testfind/add-readFile-feature-to-testfind branch from 131e427 to 2642e09 Compare September 16, 2022 11:19
@HediBenFraj HediBenFraj changed the title testfind: add read file functionality Testfind: Reuse-filedaemon-logic-in-testfind Sep 16, 2022
@HediBenFraj HediBenFraj changed the title Testfind: Reuse-filedaemon-logic-in-testfind testfind: reuse-filedaemon-logic-in-testfind Sep 16, 2022
@HediBenFraj HediBenFraj requested a review from pstorz September 16, 2022 11:34
@HediBenFraj HediBenFraj marked this pull request as draft September 16, 2022 11:37
pstorz
pstorz reviewed Sep 16, 2022
View reviewed changes
@HediBenFraj HediBenFraj changed the title testfind: reuse-filedaemon-logic-in-testfind testfind: reuse-filedaemon-logic Sep 22, 2022
@HediBenFraj HediBenFraj changed the title testfind: reuse-filedaemon-logic testfind: reusen filedaemon logic Sep 22, 2022
@HediBenFraj HediBenFraj changed the title testfind: reusen filedaemon logic testfind: reuse filedaemon logic Sep 22, 2022
@HediBenFraj HediBenFraj requested a review from pstorz September 22, 2022 14:36
@arogge arogge added the onhold label Oct 6, 2022
@HediBenFraj HediBenFraj removed the onhold label Nov 2, 2022
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/build-testfind/add-readFile-feature-to-testfind branch 5 times, most recently from 2f6f121 to 9a2930c Compare November 9, 2022 14:51
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/build-testfind/add-readFile-feature-to-testfind branch from 9a2930c to c31efef Compare November 24, 2022 12:24
@pstorz pstorz added the nobuild label Dec 1, 2022
alaaeddineelamri and others added 28 commits March 2, 2023 18:16
@alaaeddineelamri @arogge
refactor: remove CheckResources duplication
4e78fde
@alaaeddineelamri @arogge
refactor: change return value of TermFindFiles
86450c4 
It turns out that `TermFindFiles` and  `TermFindOne` were made
to return hard links just for testfind. Nowhere else in the code is 
hard links count used.
Testfind will later directly get the count from its own fileset without 
the need for calling `TermFindFiles`
@alaaeddineelamri @arogge
refactor: fd_cmds: remove SendExcludeList
8f59030 
`SendExcludeList` doesn't do anything, and is now just a placeholder. 
`SendIncludeList` does the job for both Include and Exclude lists, 
so it is now renamed accordingly
@alaaeddineelamri @arogge
refactor: fd_cmds.cc: remove unnecessary bailout
58e4ed5
@alaaeddineelamri @arogge
refactor: fd_cmds.cc: extract functions and update loops
6263723
@alaaeddineelamri @arogge
refactor: fd_cmds.cc: extract sending include exclude items
69ce6c2
@alaaeddineelamri @arogge
refactor: move SendIncludeExcludeItems to its own file
eae9cca
@alaaeddineelamri @arogge
tests: explain link between skipped gtests and systemtest
390ad97
@alaaeddineelamri @arogge
dir_cmd: lock and unlock resource when getting client
718c433
@alaaeddineelamri @arogge
systemtest: update testfind systemtest
5d2c34f
@alaaeddineelamri @arogge
testfind: fake dird-fd communication when sending filesets
408797c 
- Faking how sockets work to mimick the real interaction between 
dird and fd
- Renamed `testfind_jcr` to `testfind_fd`
- Moved testfind from dird to tools
- Enabled joblog messages
asd
@alaaeddineelamri @arogge
testfind: make stats uint_64_t
eb0f4ac
@alaaeddineelamri @arogge
testfind: replace result printf with std::cout
d81c19c
@alaaeddineelamri @arogge
testfind: fix crash when fileset not found
575ebad
@alaaeddineelamri @arogge
filed: update error messages
97eaf0e
@alaaeddineelamri @arogge
remove leftover TermMsg
01d8d28
@alaaeddineelamri @arogge
filed: extract key initilization
b04654b
@alaaeddineelamri @arogge
apply bareos-check-sources
fd5f94c
@alaaeddineelamri @arogge
testfind: simplify things and remove the unneccessary
5fafb26
@alaaeddineelamri @arogge
filed: bring back old blastdatatostorage
27d32ec
@alaaeddineelamri @arogge
filed: remove extra parameter from BlastDataToStorage
a02ae84
@alaaeddineelamri @arogge
testfind: remove even more clutter
bcc043e
@alaaeddineelamri @arogge
findlib: remove compatible check
85102f4
@alaaeddineelamri @arogge
dir_cmd: bring back NewFileJcr to be static
ed97646
@alaaeddineelamri @arogge
testfind: update systemtest
3ce79fd
@alaaeddineelamri @arogge
systemtest: check read permission instead of user
e4bc7a6
@alaaeddineelamri @arogge
testfind: use unique pointer for handling jcr
88a4fba
@arogge
Update CHANGELOG.md
e7425c5
@arogge arogge force-pushed the dev/HediBenFraj/build-testfind/add-readFile-feature-to-testfind branch from e3e7ebb to e7425c5 Compare March 2, 2023 17:16
@arogge arogge merged commit d03eace into bareos:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebsura sebsura sebsura approved these changes

@pstorz pstorz Awaiting requested review from pstorz

@alaaeddineelamri alaaeddineelamri Awaiting requested review from alaaeddineelamri

Assignees

@pstorz pstorz

@alaaeddineelamri alaaeddineelamri

@sebsura sebsura

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@HediBenFraj @pstorz @alaaeddineelamri @sebsura @arogge @bruno-at-bareos

Comments