Skip to content

Deprecate python2 plugins#1331

Merged
pstorz merged 2 commits intomasterfrom
dev/pstorz/master/deprecate-python2-plugins
Dec 13, 2022
Merged

Deprecate python2 plugins#1331
pstorz merged 2 commits intomasterfrom
dev/pstorz/master/deprecate-python2-plugins

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Dec 12, 2022

Thank you for contributing to the Bareos Project!

This PR deprecates python2 plugins. An job warning is issued on every job using a python2 plugin in the newPlugin() function of each python2 plugin(fd, sd, dir)

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@pstorz pstorz requested a review from arogge December 12, 2022 12:34
@pstorz pstorz self-assigned this Dec 12, 2022
@arogge arogge changed the title python plugins: deprecate python2 Deprecate python2 plugins Dec 13, 2022
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@pstorz pstorz force-pushed the dev/pstorz/master/deprecate-python2-plugins branch from ecde943 to b7d0e9d Compare December 13, 2022 17:13
@pstorz pstorz merged commit 0c63fc8 into master Dec 13, 2022
@pstorz pstorz deleted the dev/pstorz/master/deprecate-python2-plugins branch December 13, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments