Skip to content

VMware Plugin: introduce pyVmomi 8.x compatibility#1352

Merged
pstorz merged 2 commits intomasterfrom
dev/sduehr/master/fix-for-pyvmomi8
Jan 19, 2023
Merged

VMware Plugin: introduce pyVmomi 8.x compatibility#1352
pstorz merged 2 commits intomasterfrom
dev/sduehr/master/fix-for-pyvmomi8

Conversation

@sduehr
Copy link
Member

@sduehr sduehr commented Jan 10, 2023

In pyVmomi 8.0 the SmartConnectNoSSL() method was removed. This change uses SmartConnect with the disableSslCertValidation=True parameter instead. As it was added in pyVmomi 7.0.2 this is now the minimum required version, this was added to the documentation.

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@pstorz pstorz changed the title VMware Plugin: pyVmomi 8.x compatibility VMware Plugin: introduce pyVmomi 8.x compatibility Jan 19, 2023
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pstorz pstorz self-requested a review January 19, 2023 14:45
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

sduehr and others added 2 commits January 19, 2023 15:46
In pyVmomi 8.0 the SmartConnectNoSSL() method was removed.
This change uses SmartConnect with the disableSslCertValidation=True
parameter instead. As it was added in pyVmomi 7.0.2 this is now the
minimum required version, this was added to the documentation.
@pstorz pstorz force-pushed the dev/sduehr/master/fix-for-pyvmomi8 branch from 723082f to 314e91e Compare January 19, 2023 14:46
@pstorz pstorz merged commit fea1021 into master Jan 19, 2023
@pstorz pstorz deleted the dev/sduehr/master/fix-for-pyvmomi8 branch January 19, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments