packaging: systemd unit: set a limit of restart#1450
Merged
pstorz merged 5 commits intobareos:masterfrom May 15, 2023
Merged
Conversation
mschiff
pushed a commit
to mschiff/bareos
that referenced
this pull request
Apr 20, 2023
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos
force-pushed
the
dev/bruno/master/packaging-service-limit-number-of-restart
branch
2 times, most recently
from
6bb2c49 to
e2a1457
Compare
pstorz
changed the title
pstorz
reviewed
May 4, 2023
Member
pstorz
left a comment
pstorz
left a comment
There was a problem hiding this comment.
Good work! Please see suggested changes!
bruno-at-bareos
force-pushed
the
dev/bruno/master/packaging-service-limit-number-of-restart
branch
2 times, most recently
from
4b0bc41 to
b275c75
Compare
15 tasks
pstorz
force-pushed
the
dev/bruno/master/packaging-service-limit-number-of-restart
branch
from
b275c75 to
04ad073
Compare
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- insert a limit burst of ten restart per day after a three minutes wait. - increase allowed number of open files with LimitNOFILE=8192:524288 we are not limited by select(2) 1024 limit. - Add ConditionPathIsDirectory=@working_dir@ to sd,fd service Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
pstorz
force-pushed
the
dev/bruno/master/packaging-service-limit-number-of-restart
branch
from
a5592d9 to
b28f797
Compare
bruno-at-bareos
deleted the
dev/bruno/master/packaging-service-limit-number-of-restart
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to enable automatic restart of daemon, but with a certain limit.
This will avoid constant crashing of daemon, which need an administrative review of their configuration.
We insert a limit burst of ten restart per day after a three minutes wait.
We also insert an increase in nb of open files
We add the conditional test for working directory on all daemons
OP#5453 OP#5461
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality