backup report: show negative compression#1598
Merged
BareosBot merged 5 commits intobareos:masterfrom Dec 18, 2023
Merged
Conversation
sebsura
reviewed
Nov 15, 2023
sebsura
approved these changes
Nov 16, 2023
Contributor
sebsura
left a comment
sebsura
left a comment
There was a problem hiding this comment.
Looks good to me. I was bitten by this already so i appreciate this change.
Member
|
Can't we fix the underlying problem? i.e. don't write the compressed record if it is bigger than the uncompressed one. And maybe keep a statistic how often this happens and then skip further record compression if the file seems to be incompressible? |
Contributor
|
That should be doable. |
sebsura
reviewed
Nov 28, 2023
Member
|
Builds fails as this still uses the old |
pstorz
force-pushed
the
dev/pstorz/master/show-negative-compression
branch
2 times, most recently
from
bcf0961 to
181e7f9
Compare
We now also display a negative compression rate in the job log, before it was changed to "None". This is an important information as it suggests the administrator to disable compression.
This also fixes the unescaped % inside a format string
BareosBot
force-pushed
the
dev/pstorz/master/show-negative-compression
branch
from
d2639db to
5142059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality