tools: add dedup estimation tool bdedupestimate#1654
Merged
BareosBot merged 28 commits intobareos:masterfrom May 23, 2024
Merged
tools: add dedup estimation tool bdedupestimate#1654BareosBot merged 28 commits intobareos:masterfrom
bdedupestimate#1654BareosBot merged 28 commits intobareos:masterfrom
Conversation
pstorz
changed the title
bdedupestimate
pstorz
requested changes
Feb 2, 2024
Member
pstorz
left a comment
pstorz
left a comment
There was a problem hiding this comment.
Create a manpage for bdedupestimate please.
sebsura
force-pushed
the
dev/ssura/master/dedup-estimate
branch
from
f4a24a2 to
db878a4
Compare
pstorz
requested changes
Mar 28, 2024
Member
pstorz
left a comment
pstorz
left a comment
There was a problem hiding this comment.
Wouldn't it make sense to have a system test that runs bdedupestimate?
6 tasks
sebsura
force-pushed
the
dev/ssura/master/dedup-estimate
branch
4 times, most recently
from
f779e67 to
b178f01
Compare
pstorz
requested changes
May 14, 2024
Member
pstorz
left a comment
pstorz
left a comment
There was a problem hiding this comment.
- dedup factor format should be
2.34x(like ZFS does the output) and notx2.34. See comment - Some commits still contain "Fixup"
sebsura
force-pushed
the
dev/ssura/master/dedup-estimate
branch
from
b178f01 to
1ef2048
Compare
pstorz
approved these changes
May 16, 2024
pstorz
force-pushed
the
dev/ssura/master/dedup-estimate
branch
from
1ef2048 to
c3c347e
Compare
This tool should be able to estimate how much space saving you could achive by switching to a dedupable volume layout on a deduping file system.
With this flag enabled we match complete records instead of subdividing records into datablocks.
dedup_units can now have different sizes if record based dedup is enabled. As such we should only compare the sha results if the sizes are equal.
Now that records are split into multiple blocks to make deduplication useful even if backing up smaller files, we need to adjust the estimate logic to account for that.
BareosBot
force-pushed
the
dev/ssura/master/dedup-estimate
branch
from
f995f55 to
88652ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This pr adds a tool with which you can estimate how much space you could save when using deduplication.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Tests