Merged
Conversation
joergsteffens
force-pushed
the
dev/joergs/master/updatelicense
branch
from
fd2aadd to
b4b0bb6
Compare
joergsteffens
force-pushed
the
dev/joergs/master/updatelicense
branch
from
b4b0bb6 to
f7b5eb8
Compare
arogge
requested changes
Apr 19, 2024
Member
arogge
left a comment
arogge
left a comment
There was a problem hiding this comment.
I found some minor issues with the copyright headers.
Besides that there is a small performance gain possible by omitting an API request and pylint brought up a few remarks.
Member
Author
|
I just discovered. that github now has 2 License entries. I assume, one for LICENSE.txt and on for LICENSE.template (https://github.com/bareos/bareos?tab=License-2-ov-file). |
joergsteffens
force-pushed
the
dev/joergs/master/updatelicense
branch
from
a43dcfa to
9481e89
Compare
arogge
approved these changes
May 17, 2024
Member
arogge
left a comment
arogge
left a comment
There was a problem hiding this comment.
Looks great! Sorry for taking so long to finally review this.
Add update-license subcommand to the pr-tool. It will be called automatically when merging a PR.
moved LICENSE.template to devtools/template/LICENSE.txt to prevent that Github displays 2 licenses. Also added a check to prevent manual modifications of LICENSE.txt.
BareosBot
force-pushed
the
dev/joergs/master/updatelicense
branch
from
93f887b to
f6bee17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Add update-license subcommand to the pr-tool.
It will be called automatically when merging a PR.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Required documentation changes are present and part of the PR