Skip to content

dird: remove BaseJob directives#1969

Merged
BareosBot merged 13 commits intobareos:masterfrom
pstorz:dev/pstorz/master/remove-basejobs
Nov 18, 2024
Merged

dird: remove BaseJob directives#1969
BareosBot merged 13 commits intobareos:masterfrom
pstorz:dev/pstorz/master/remove-basejobs

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Sep 30, 2024

The Basejobs have been deprecated already in Bareos 23, now we also remove the configuration options:

  • Base in Job Resource
  • BaseJob Options in FileSet Resource

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@sebsura
Copy link
Contributor

sebsura commented Oct 7, 2024

Should we add the jit reservation = yes default here ?

@arogge arogge added the removal this PR removes functionality label Oct 8, 2024
@arogge arogge added this to the 24.0.0 milestone Oct 8, 2024
@pstorz pstorz requested a review from arogge October 23, 2024 12:17
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions/remarks:

  • What about Base in Include->Options ?
  • In inc_conf.cc you should remove the define for PERMITTED_BASEJOB_OPTIONS
  • We can also remove INC_KW_BASEJOB and its keyword as we do not handle them anymore
  • similarly we can remove CFG_TYPE_BASE, StoreBase, etc. as they are not used anymore (after we remove the base option)
  • What about the fd ? Should it also reject base jobs now ? findFOPTS should probably also remove BaseJobOpts and alist<> base (and the parsing code)

@pstorz pstorz force-pushed the dev/pstorz/master/remove-basejobs branch from 9d9c8dd to 2be1d58 Compare November 8, 2024 11:26
@pstorz pstorz requested a review from sebsura November 15, 2024 08:39
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BareosBot BareosBot merged commit 639dade into bareos:master Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

removal this PR removes functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments