dird: remove BaseJob directives#1969
Merged
BareosBot merged 13 commits intobareos:masterfrom Nov 18, 2024
Merged
Conversation
Contributor
|
Should we add the jit reservation = yes default here ? |
sebsura
requested changes
Nov 8, 2024
Contributor
There was a problem hiding this comment.
Some questions/remarks:
- What about Base in Include->Options ?
- In inc_conf.cc you should remove the define for PERMITTED_BASEJOB_OPTIONS
- We can also remove INC_KW_BASEJOB and its keyword as we do not handle them anymore
- similarly we can remove CFG_TYPE_BASE, StoreBase, etc. as they are not used anymore (after we remove the base option)
- What about the fd ? Should it also reject base jobs now ? findFOPTS should probably also remove BaseJobOpts and alist<> base (and the parsing code)
The Basejobs have been deprecated already in Bareos 23, now we also remove the configuration options: - Base in Job Resource - BaseJob Options in FileSet Resource
9d9c8dd to
2be1d58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Basejobs have been deprecated already in Bareos 23, now we also remove the configuration options:
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality