Fix 32bit compilation

[AlexanderS]

Thank you for contributing to the Bareos Project!

While compiling a debian package for armhf (32bit) I encountered two errors.

The first errors in src/stored/backends/chunked_device.cc :

core/src/stored/backends/chunked_device.cc: In member function ‘ssize_t storagedaemon::ChunkedDevice::ReadChunked(int, void*, size_t)’:
core/src/include/bc_types.h:113:26: error: comparison of integer expressions of different signedness: ‘ssize_t’ {aka ‘int’} and ‘uint32_t’ {aka ‘unsigned int’} [-Werror=sign-compare]
  113 | #  define MIN(a, b) ((a) < (b) ? (a) : (b))
      |                      ~~~~^~~~~
core/src/stored/backends/chunked_device.cc:685:13: note: in expansion of macro ‘MIN’
  685 |           = MIN((ssize_t)count, (current_chunk_->buflen - wanted_offset));
      |             ^~~
core/src/stored/backends/chunked_device.cc: In member function ‘ssize_t storagedaemon::ChunkedDevice::WriteChunked(int, const void*, size_t)’:
core/src/stored/backends/chunked_device.cc:846:46: error: comparison of integer expressions of different signedness: ‘ssize_t’ {aka ‘int’} and ‘uint32_t’ {aka ‘unsigned int’} [-Werror=sign-compare]
  846 |             if ((wanted_offset + bytes_left) > current_chunk_->buflen) {

These errors are likely caused because the casts were just forgotten. There are multiple similar code lines around the locations with the appropriate casts.

The second error in core/src/stored/backends/dedupable/volume.cc:

core/src/stored/backends/dedupable/volume.cc: In constructor ‘dedup::data::data(dedup::{anonymous}::open_context, const dedup::config&)’:
core/src/stored/backends/dedupable/volume.cc:231:61: error: narrowing conversion of ‘(uint64_t)bf.dedup::config::block_file::End’ from ‘uint64_t’ {aka ‘long long unsigned int’} to ‘dedup::fvec<dedup::block>::size_type’ {aka ‘unsigned int’} [-Werror=narrowing]
  231 |   blocks = decltype(blocks){ctx.read_only, bfd.fileno(), bf.End};
      |                                                          ~~~^~~
core/src/stored/backends/dedupable/volume.cc:232:59: error: narrowing conversion of ‘(uint64_t)pf.dedup::config::part_file::End’ from ‘uint64_t’ {aka ‘long long unsigned int’} to ‘dedup::fvec<dedup::part>::size_type’ {aka ‘unsigned int’} [-Werror=narrowing]
  232 |   parts = decltype(parts){ctx.read_only, pfd.fileno(), pf.End};
      |                                                        ~~~^~~

These are errors in the new Dedupable Storage Backend. The pull request does not alter any data types of any field because I believe that the dedup::config structures are directly serialized into the files on the storage. So the implementation simply throws. if the config contains values that are too large.

Please check

• Short description and the purpose of this PR is present above this paragraph
• Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

• Git Workflow
• Automatic Sourcecode Formatting
• Check your commit messages
• Boy Scout Rule

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General

• Is the PR title usable as CHANGELOG entry?
• Purpose of the PR is understood
• Commit descriptions are understandable and well formatted
  Required backport PRs have been created
• Correct milestone is set

Source code quality

• Source code changes are understandable
• Variable and function names are meaningful
• Code comments are correct (logically and spelling)
• Required documentation changes are present and part of the PR

[sebsura]

Thanks for your work!