systemtests: add config-default test#2332
Merged
BareosBot merged 4 commits intobareos:masterfrom Aug 7, 2025
Merged
Conversation
bruno-at-bareos
force-pushed
the
dev/bruno/master/issue-2237-systemtest-defaultconfig
branch
2 times, most recently
from
d752db6 to
ecd3d92
Compare
Contributor
Author
|
@sebsura do you think we should try to make it working on Windows testing. If yes, what is my best approach to learn how to do so ? |
bruno-at-bareos
force-pushed
the
dev/bruno/master/issue-2237-systemtest-defaultconfig
branch
2 times, most recently
from
a5c880c to
85dcab8
Compare
bruno-at-bareos
force-pushed
the
dev/bruno/master/issue-2237-systemtest-defaultconfig
branch
2 times, most recently
from
c093f68 to
332a3d9
Compare
sebsura
requested changes
Aug 6, 2025
sebsura
requested changes
Aug 6, 2025
bruno-at-bareos
force-pushed
the
dev/bruno/master/issue-2237-systemtest-defaultconfig
branch
from
332a3d9 to
e053b63
Compare
- BareosSystemtestFunctions.cmake + remove unused copy of defaultsconfig, bconsole.conf + add `systemtests/tests/config-default` - systemtests/CMakeLists.txt + add bareos-tray-monitor in binary list - systemtest/environment.in + add BAREOS_TRAY_MONITOR_BINARY - do not test traymonitor if not build - use translated path variable BAREOS_WORKING_DIR - Exclude backend directory for Windows tests ``Backend Directory`` is only valid for dynamic backend, on Windows backends are statically build - use future normalized BAREOS_CONFIG_DIR variable - use WINDIR variable to detect if running on windows - use new SKIP_BAREOS_STATUS for default start_test function - use check_config function from bareos-ctl-func Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
sebsura
force-pushed
the
dev/bruno/master/issue-2237-systemtest-defaultconfig
branch
from
e053b63 to
008ceca
Compare
sebsura
approved these changes
Aug 7, 2025
Contributor
|
This is a great new test, thanks for your work! |
bruno-at-bareos
deleted the
dev/bruno/master/issue-2237-systemtest-defaultconfig
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce a new systemtest, we test prepared and distributed defaultsconfigs.
systemtests/tests/config-defaultBackend Directoryis only valid for dynamic backend,on Windows backends are statically build
Fix #2237
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality