Skip to content

ndmp native: fix problem with new 'unlabeled' media status#2456

Merged
BareosBot merged 5 commits intobareos:masterfrom
pstorz:dev/pstorz/master/ndmp-native-unlabeled-status
Nov 26, 2025
Merged

ndmp native: fix problem with new 'unlabeled' media status#2456
BareosBot merged 5 commits intobareos:masterfrom
pstorz:dev/pstorz/master/ndmp-native-unlabeled-status

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Nov 25, 2025

This PR aims to fix the Unlabeled status in ndmp-native after latest changes in master.

Fix bareos/internal#445

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests

Will be all in #2384

@pstorz pstorz added this to the 25.0.0 milestone Nov 25, 2025
@pstorz pstorz added the bugfix label Nov 25, 2025
@bruno-at-bareos bruno-at-bareos self-requested a review November 25, 2025 08:24
@bruno-at-bareos bruno-at-bareos changed the title native ndmp: fix problem with new 'unlabeled' media status ndmp native: fix problem with new 'unlabeled' media status Nov 25, 2025
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes and code improvements.
After new testing, no more crash nor misbehavior were detected.

@pstorz pstorz force-pushed the dev/pstorz/master/ndmp-native-unlabeled-status branch from 9427713 to c4a0cf4 Compare November 25, 2025 15:28
@bruno-at-bareos bruno-at-bareos self-requested a review November 26, 2025 08:42
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed last changes. All green for me.

@BareosBot BareosBot force-pushed the dev/pstorz/master/ndmp-native-unlabeled-status branch from bd4fe06 to 288cedf Compare November 26, 2025 09:44
@BareosBot BareosBot merged commit e000b94 into bareos:master Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments