Fixed JobDetails joblog messages order#509
Merged
frb121 merged 3 commits intobareos:masterfrom May 12, 2020
Merged
Conversation
Add an id to each joblog entry to fix the sorting problem on the details page.
This fixes the problem that occurs when multiple joblog messages have the same time. It uses the id field added in eda19fc
It makes more sense to call the column just "#"
Contributor
|
Thanks for the PR, Alvaro. |
frb121
approved these changes
May 12, 2020
Contributor
frb121
left a comment
frb121
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have multiple log messages with the same time the display order is weird. For example, lets say we have this joblogs in this order returned from bconsole:
If we order them by desc time, we expect to have:
But we are getting:
By adding an Id to each message we can solve this problem.