build: enable c++17 and use some c++14/17 features#741
Merged
Conversation
pstorz
force-pushed
the
dev/pstorz/master/c++17
branch
4 times, most recently
from
9984191 to
b19062b
Compare
arogge
reviewed
Feb 23, 2021
Member
arogge
left a comment
arogge
left a comment
There was a problem hiding this comment.
I have some minor remarks. Overall great work!
core/src/tests/test_edit.cc
Outdated
Comment on lines
30
to
35
Member
There was a problem hiding this comment.
Do we want to keep this? I think it was great for testing, but maybe not for the master branch.
We could do something like that in core/src/compile_tests, so we can make sure string_view actually works.
Most of the interesting C++17 features will require gcc-7 and libstdc++-7 nevertheless, so we won't really need that workaround in the long term.
Member
Author
There was a problem hiding this comment.
I agree, I just pushed a commit that removes these parts.
core/src/tests/test_edit.cc
Outdated
Comment on lines
61
to
62
pstorz
force-pushed
the
dev/pstorz/master/c++17
branch
6 times, most recently
from
fe40a5e to
bc73302
Compare
pstorz
force-pushed
the
dev/pstorz/master/c++17
branch
2 times, most recently
from
673f2f6 to
44acf0a
Compare
- Enable c++17 support in cmake - Avoid warnings because the "register" keyword was removed in c++17 - NDMP files generated by rpcgen - Python2 header files - Windows: glob.cc - Use c++14 digit separator (1'000'000)
pstorz
force-pushed
the
dev/pstorz/master/c++17
branch
from
44acf0a to
fd5721d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow these few prerequisites before you hand in a PR
Consider the following chapters in the Bareos Developer Documentation
Add some information
Keep spirit!