Python > 3.7 error with libcloud and postgresql fd plugin#769
Merged
Conversation
cf67bae to
4b7c744
Compare
e7c99d7 to
b00f444
Compare
Member
|
I've tested the pyplug-fd-postgres on different platforms and it works/fails as described. |
joergsteffens
approved these changes
Mar 26, 2021
Member
joergsteffens
left a comment
There was a problem hiding this comment.
The pyplug-fd-postgres part looks good.
a2eba65 to
36f42e6
Compare
4301ff3 to
68d55bc
Compare
a80cb07 to
2104b10
Compare
Co-authored-by: Jörg Steffens <joergsteffens@users.noreply.github.com>
2104b10 to
e437fb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Python > 3.7 the libcloud and postgresql plugins do not work anymore.
The suggested change in this PR is to write an error message to the joblog and cancel the job.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests