Skip to content

Python > 3.7 error with libcloud and postgresql fd plugin#769

Merged
pstorz merged 4 commits intomasterfrom
dev/franku/master/py-3.8-error
Mar 29, 2021
Merged

Python > 3.7 error with libcloud and postgresql fd plugin#769
pstorz merged 4 commits intomasterfrom
dev/franku/master/py-3.8-error

Conversation

@franku
Copy link
Contributor

@franku franku commented Mar 23, 2021

With Python > 3.7 the libcloud and postgresql plugins do not work anymore.

The suggested change in this PR is to write an error message to the joblog and cancel the job.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

@franku franku changed the title Python 3.8 error with libcloud and postgresql fd plugin Python > 3.7 error with libcloud and postgresql fd plugin Mar 23, 2021
@franku franku force-pushed the dev/franku/master/py-3.8-error branch from cf67bae to 4b7c744 Compare March 23, 2021 15:01
@franku franku force-pushed the dev/franku/master/py-3.8-error branch from e7c99d7 to b00f444 Compare March 26, 2021 08:31
@joergsteffens
Copy link
Member

I've tested the pyplug-fd-postgres on different platforms and it works/fails as described.

Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyplug-fd-postgres part looks good.

@franku franku force-pushed the dev/franku/master/py-3.8-error branch 2 times, most recently from a2eba65 to 36f42e6 Compare March 26, 2021 13:47
@franku franku force-pushed the dev/franku/master/py-3.8-error branch 2 times, most recently from 4301ff3 to 68d55bc Compare March 26, 2021 16:06
@pstorz pstorz force-pushed the dev/franku/master/py-3.8-error branch 2 times, most recently from a80cb07 to 2104b10 Compare March 29, 2021 10:39
@pstorz pstorz force-pushed the dev/franku/master/py-3.8-error branch from 2104b10 to e437fb3 Compare March 29, 2021 10:41
@pstorz pstorz merged commit 1a27fa6 into master Mar 29, 2021
@pstorz pstorz deleted the dev/franku/master/py-3.8-error branch March 29, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments