Github workflow action for building & releasing Bitshares beet#192
Github workflow action for building & releasing Bitshares beet#192sschiessl-bcp merged 4 commits intobitshares:developfrom grctest:action
Conversation
I found this: yarnpkg/yarn#8054 (comment):
|
babel runtime installed and added to allowlist small babel config change build script uses npm
|
Cool, that's github actions successfully building windows setup: https://github.com/grctest/beet/releases/tag/v1.0.3 |
|
Looks like appveyor still wants to run without the appveyor file? |
|
Looks also like it is (sometimes?) working https://ci.appveyor.com/project/clockworkgr/beet/builds/44753286/artifacts Possible we need to tun the link off from AppVeyor end too... |
Additional os packages
|
As far as I can tell the action workflow has successfully built and packaged the linux deb + appimage, as well as macos dmg. https://github.com/grctest/beet/releases/tag/v1.0.9 (not tested running these new packages on their respective os yet) |
|
RE |
|
I've successfully implemented virustotal scanning of deliverables in another repo, should we add this to beet too? In order to establish presence as a safe application in all/most antivirus apps. https://github.com/BTS-CM/NFT_Viewer/releases/tag/v1.0.26 https://github.com/BTS-CM/NFT_Viewer/blob/main/.github/workflows/node.js.yml https://hive.blog/bitshares/@nftea.gallery/automatically-scanning-release-binaries-with-over-70-antiviruses-via-virustotal-in-github-action-workflows |
|
Did you see the changelist actions https://github.com/bitshares/bitshares-ui/blob/c0a2774f8703b23743c97fe159f19f946770e497/.github/workflows/build-release-binaries.yml#L43, and what is the reason to use a custom release actions instead of actions/create-release? |
actions/create-release is unmaintained & archived, they recommended https://github.com/softprops/action-gh-release which I then forked to freeze our use to a specific commit to reduce risk of potential supply chain attack, perhaps we can use the softprops with a specific commit rather than fork the repo |
Do you want to use that action repo for changelogs? What do you think of this action instead? https://github.com/marketplace/actions/release-changelog-builder |
Avoid adding duplicate accounts in the same wallet Fix wallet name bug during creation Avoid using text component
|
@sschiessl-bcp Any further thoughts on the above? |
Not at the moment |
3 participants
Still a WIP, the output setup results in the following error after launching the app post install:
cannot find module '@babel/runtime/helpers/asyncToGenerator'I've tried installing the @babel/runtime package but this doesn't change the error.
The workflow focuses on the windows build for now, however once fully operational the next priority is suppporting linux/macos.