Skip to content

Extra languages#232

Merged
sschiessl-bcp merged 2 commits intobitshares:developfrom
grctest:translations
Feb 26, 2023
Merged

Extra languages#232
sschiessl-bcp merged 2 commits intobitshares:developfrom
grctest:translations

Conversation

@grctest
Copy link
Contributor

@grctest grctest commented Jan 24, 2023

danish, spanish, estonian, french, italian, japanese, korean, portugese and thai

danish, spanish, estonian, french, italian, japanese, korean, portugese and thai
@sschiessl-bcp
Copy link
Collaborator

How is the quality of those translations? Machine translated?

@grctest
Copy link
Contributor Author

grctest commented Jan 26, 2023

Yeah they were translated using the following tool: https://translate.i18next.com

The tool uses google translate, but avoids translating the keys (which can happen if you try to translate i18n json via the ui).

The tool recommends using locize if we want a better experience, but more languages would need a scrolling language dropdown menu and a more scalable method of importing the i18n json files.

@sschiessl-bcp
Copy link
Collaborator

Could we do a on-the-fly translation button? We only maintain "en" language, and user can select a language and it gets auto translated?

@grctest
Copy link
Contributor Author

grctest commented Jan 26, 2023

I don't think so without paying for a premium service.

We would also need to take into consideration the geo-blocking of some translation services which users may run into.

@sschiessl-bcp
Copy link
Collaborator

Do we know anyone to proofread? Not sure if autotranslated makes UX easier, especially in such technical terms. What do you think?=

@grctest
Copy link
Contributor Author

grctest commented Jan 27, 2023

Requiring a peer review for each new language sounds good to me, asking the community is probably the best bet.

Just reading the locale files might not make sense, checking out the locale use in app might be required of the peer reviewers.

Remove references to 'beet' branding in strings
Updated all translations
Create static string for beet header string
@grctest
Copy link
Contributor Author

grctest commented Feb 18, 2023

Updated the translations, taking telegram feedback into account the beet branding has been removed from the translation files to avoid beet being translated like a vegetable, lol.

The HTLC acronym has been extended to 'hash time locked contract' then translated in the non-english locales.

@sschiessl-bcp sschiessl-bcp merged commit 39325ca into bitshares:develop Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants