Merged
Conversation
I've come to the conclusion that Task isn't buying us much value over Command. I'd like to eventually drop it. This is just getting the ball rolling. Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request starts the process of removing the custom Task abstraction and replacing it with std::process::Command, extended by the CommandRunExt trait. The changes in crates/lib/src/install/osbuild.rs are a good first step in this direction.
The refactoring is clean and improves the code by removing a layer of abstraction and using a standard, fluent builder pattern for command execution. The implementation is correct and aligns well with the stated goal of the pull request. I found no issues with the proposed changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've come to the conclusion that Task isn't buying us much value over Command.
I'd like to eventually drop it. This is just getting the ball rolling.