Revert "blockdev: implement signal-safe loopback device cleanup helper"#1440
Revert "blockdev: implement signal-safe loopback device cleanup helper"#1440cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
This reverts commit c2c918c. As it makes install to-disk fail: bootc-dev#1439
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts commit c2c918cc which introduced a signal-safe loopback device cleanup helper. The revert is necessary because the feature caused install to-disk to fail, as reported in issue #1439.
The changes correctly remove the cleanup helper implementation from the blockdev crate, including the associated data structures, functions, and dependencies (libc, rustix, tempfile, tokio). The corresponding loopback-cleanup-helper internal CLI command is also removed from the bootc-lib crate.
The revert appears to be clean and complete. I've reviewed the removed code and dependencies, and the changes are consistent with undoing the problematic commit. This should resolve the installation failure.
2 participants
This reverts commit c2c918c.
As it makes install to-disk fail:
#1439