Merged
Conversation
Also pull in `composefs-boot` and `composefs-oci` Signed-off-by: Johan-Liebert1 <pragyanpoudyal41999@gmail.com>
1 task
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request bumps the composefs-rs dependency and adds composefs-boot and composefs-oci as new dependencies. The code changes in crates/lib/src/cli.rs and crates/ostree-ext/src/fsverity.rs correctly adapt to the API changes from the updated dependency. The dependency declarations in crates/ostree-ext/Cargo.toml are correct but could be improved for maintainability by leveraging workspace dependencies to avoid repetition of the git repository and revision, which I've commented on. Overall, the changes look good and align with the PR's objective.
cgwalters
approved these changes
Jul 24, 2025
| let fd = | ||
| std::fs::File::open(&path).with_context(|| format!("Reading {path}"))?; | ||
| fsverity::enable_verity::<fsverity::Sha256HashValue>(&fd)?; | ||
| fsverity::enable_verity_raw::<fsverity::Sha256HashValue>(&fd)?; |
Collaborator
There was a problem hiding this comment.
This is the most direct change and is fine for now but we should do a followup that uses the retry variants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also pull in
composefs-bootandcomposefs-oci