Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces value_of and value_of_utf8 helper methods to the Cmdline struct, simplifying the process of retrieving kernel argument values. The value_of_utf8 method correctly handles potential UTF-8 errors, which is an improvement over the value_lossy method it replaces in one instance. The changes are well-tested. My main feedback is a small refactoring suggestion to improve code reuse.
Many cases want to find the value of an argument, no need to return the key back to them. Also IMO `value_lossy()` is a HUGE trap because aside from logging it's almost never the right thing to do. I plan to remove it in a followup. So this also adds a `utf8` helper that returns an error, and changes one case to use it. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
kernel-cleanups
branch
from
1ad22a8 to
58a37d7
Compare
jeckersb
approved these changes
Aug 4, 2025
Collaborator
jeckersb
left a comment
jeckersb
left a comment
There was a problem hiding this comment.
👍 very nice improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many cases want to find the value of an argument, no need to return the key back to them.
Also IMO
value_lossy()is a HUGE trap because aside from logging it's almost never the right thing to do. I plan to remove it in a followup.So this also adds a
utf8helper that returns an error, and changes one case to use it.