ci: Refactor release action to use app and create-pull-request#1494
ci: Refactor release action to use app and create-pull-request#1494ckyrouac merged 1 commit intobootc-dev:mainfrom
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
I am not the owner of the repo anymore, CNCF is right?
Ah. That seems...a bit dangerous to me. AFAIK the more tedious but also more secure/correct way is to make a Github App https://docs.github.com/en/apps/creating-github-apps/about-creating-github-apps/deciding-when-to-build-a-github-app Last I looked, it wasn't terribly hard and would help unblock other automations too. |
|
Ah - looks like we can just create an empty app and use the generated token in the action via this: https://github.com/actions/create-github-app-token. I don't have permissions to the bootc-dev org settings to add the app though. Is that something I need to request from CNCF? |
|
I was wrong and I am an Owner in the org as are several other people, you were not. I invited you. I am not sure what syncs that (but it's definitely something we want to automate from MAINTAINERS.md) or some other source of truth. |
This uses the token generated in the GitHub app that has a limited scope. Also refactors the commit/push steps to use the create-pull-request action rather than manually committing and pushing. This simplifies the token usage when committing/pushing. Signed-off-by: ckyrouac <ckyrouac@redhat.com>
|
thanks for adding me! I reworked this to use the GH app. |
This uses the token generated in the GitHub app that has a limited
scope. Also refactors the commit/push steps to use the
create-pull-request action rather than manually committing and pushing.
This simplifies the token usage when committing/pushing.