Conversation
Signed-off-by: Johan-Liebert1 <pragyanpoudyal41999@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request bumps the composefs-rs dependency to a newer revision. The changes are straightforward, including updates to Cargo.lock and Cargo.toml, and a necessary adaptation in the source code to match the updated API of the dependency. The changes look correct. I have one suggestion to improve the maintainability of the dependency specification in Cargo.toml.
|
Error from the Centos-stream-10 CI jobs is a RPM dependency issue in the build: The Fedora job failures are definitely unrelated to this PR: |
bshephar
left a comment
There was a problem hiding this comment.
Seems like the change itself doesn't cause any issues. I don't see how the RPM dependency issue or the image pull could be related to this.
| OciCommand::Pull { ref image, name } => { | ||
| let (sha256, verity) = composefs_oci::pull(&repo, image, name.as_deref()).await?; | ||
| let (sha256, verity) = | ||
| composefs_oci::pull(&repo, image, name.as_deref(), None).await?; |
There was a problem hiding this comment.
Signature changes because of the new param added to pull() here, by this commit:
composefs/composefs-rs@1a08a28#diff-202658a04902f3f6a4578fa63cf9f6111413c5acfbcccd556631a9a2135dd3ffR65
Makes sense.
I don't see anything specific in the spec file that would be a problem with this repo specifically? Possibly needs a |
Ah, it's mentioned here too: So it's a known issue and being resolved by the looks of it. |
No description provided.