rechunker: Use (path,checksum) when creating exclusive components#1513
rechunker: Use (path,checksum) when creating exclusive components#1513ckyrouac merged 1 commit intobootc-dev:mainfrom
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
cgwalters
left a comment
There was a problem hiding this comment.
I would frame this as "don't deduplicate by checksum with exclusive components" - right?
Doesn't it open the question a bit whether we should also stop doing that for non-exclusive?
I think that's OK for now, but probably worth noting.
Anyways just style nits
The way I've been thinking about it is when a user explicitly defines an exclusive component, the expectation is the files go exactly where they want. The package based rechunking is an automatic process that the user doesn't really control so it's less surprising when duplicate files are in the same layer. I'll add docs to explain this in a followup. |
This allows files with duplicate contents (and checksums) to be stored in different layers when using the rechunker. Signed-off-by: ckyrouac <ckyrouac@redhat.com>
243d001 to
72c3f9b
Compare
This allows files with duplicate contents (and checksums) to be stored in different layers when using the rechunker.