cli: hide --soft-reboot as ostree side needs further stabilization#1539
Merged
jeckersb merged 1 commit intobootc-dev:mainfrom Aug 21, 2025
Merged
cli: hide --soft-reboot as ostree side needs further stabilization#1539jeckersb merged 1 commit intobootc-dev:mainfrom
jeckersb merged 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request hides the --soft-reboot command-line option because the feature is not yet stable, as indicated in the linked issue. The changes correctly add hide = true to the clap attribute for this option in UpgradeOpts, SwitchOpts, and RollbackOpts. My feedback includes suggestions to add comments to the code to explain why the option is hidden, improving long-term maintainability.
ostreedev/ostree#3503 Signed-off-by: Joseph Marrero Corchado <jmarrero@redhat.com>
jmarrero
force-pushed
the
hide-soft-reboot
branch
from
cc952c2 to
bf45f60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ostreedev/ostree#3503