Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a set of changes to ensure compatibility with Rust 1.90. The modifications include updating the Minimum Supported Rust Version (MSRV) to 1.84.0, removing dead code identified by the new compiler version, and fixing new warnings about unnecessary parentheses. The changes are correct, well-contained, and improve the overall health of the codebase. This is a solid maintenance update.
|
Hm errors seem like fallout from #1619 ? |
|
|
||
| #[derive(Serialize, Deserialize, Debug, PartialEq, Eq)] | ||
| #[serde(rename_all = "kebab-case")] | ||
| pub(crate) enum VerityState { |
| # In general we try to keep this pinned to what's in the latest RHEL9. | ||
| # However right now, we bumped to 1.82 as that's what composefs-rs uses. | ||
| rust-version = "1.82.0" | ||
| rust-version = "1.84.0" |
There was a problem hiding this comment.
What's in c9s now is 1.88 so we can bump to that; what made you choose 1.84?
I guess really this should be updated by renovate.
There was a problem hiding this comment.
Oh sorry it's in the commit message. Yeah fine as is.
There was a problem hiding this comment.
I asked brew what was in rhel-9.6.0 to be conservative
Yes, though not obvious to me how that PR could have merged but this one fails |
FWIW I can reproduce the CI errors on main with |
|
This will just need rebasing once #1628 lands otherwise LGTM |
Signed-off-by: John Eckersberg <jeckersb@redhat.com>
Signed-off-by: John Eckersberg <jeckersb@redhat.com>
We already required at least 1.83.0 since we're using `Option::unwrap` in const context in a few places, but rust-1.90 now correctly points this out and emits an error. RHEL 9.6 is on 1.84.0 so bump to match that. Signed-off-by: John Eckersberg <jeckersb@redhat.com>
2 participants
Closes: #1605