specfile: Handle updated macros in c9s rust-toolset#1641
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Sep 24, 2025
Merged
specfile: Handle updated macros in c9s rust-toolset#1641cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the bootc.spec file to handle newer cargo-rpm-macros in the CentOS Stream 9 rust-toolset by detecting the rust minor version. The changes are logical and address the issue. I've provided a couple of suggestions to improve the robustness of the version parsing and the maintainability of the spec file by avoiding duplicated logic.
Collaborator
Author
|
wow rustc segfaulted on c10s-s390x |
Collaborator
Author
|
Closes: bootc-dev#1640 Signed-off-by: John Eckersberg <jeckersb@redhat.com>
cgwalters
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1640
Signed-off-by: John Eckersberg jeckersb@redhat.com