Merged
Conversation
To avoid duplicative content. And add comments for why we're changing some of the options. Signed-off-by: Colin Walters <walters@verbum.org>
Move libvirt installation into a parameterized input in the bootc-ubuntu-setup action, allowing workflows to opt-in via `libvirt: true`. This consolidates installation logic and makes workflows cleaner by removing duplicate package installation steps. Assisted-by: Claude Code Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
misc-ci-cleanups
branch
from
898db7d to
d5efb5a
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two useful improvements to the GitHub Actions workflow: adding an option to install virtualization tools and setting up Rust caching. The implementation is solid, but I found one minor issue for you to consider.
jmarrero
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.