Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully switches the UKI signing process from sbsign to pesign, and updates the build environment from Fedora to CentOS Stream. This change aligns with existing signing procedures and removes a dependency on Fedora. However, a significant omission is that the tests located in tmt/tests/examples/bootc-uki/ have not been updated to reflect these changes; they still utilize sbsign and Fedora. It is crucial to update these tests to ensure the new implementation is properly verified. I have also included a few specific comments on Dockerfile.cfsuki to address a critical bug and suggest some improvements.
This more closely aligns with how kernel-uki-virt is signed today, and eliminates the requirement to use Fedora for the UKI toolchain. Subsequently, this also switches the UKI toolchain to use c10s. Signed-off-by: John Eckersberg <jeckersb@redhat.com>
cgwalters
approved these changes
Oct 21, 2025
travier
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This more closely aligns with how kernel-uki-virt is signed today, and
eliminates the requirement to use Fedora for the UKI toolchain.
Subsequently, this also switches the UKI toolchain to use c10s.
Signed-off-by: John Eckersberg jeckersb@redhat.com