Fix a few instances of oddball baud rate#1697
Merged
jeckersb merged 1 commit intobootc-dev:mainfrom Oct 21, 2025
Merged
Conversation
github-actions
bot
added
area/install
Collaborator
Author
|
(If there's some reason it was purposefully like this, please chime in!) |
Claude pointed this out while I was working on something else completely unrelated. But it looks like somewhere along the way 114800 snuck its way in and probably got copy/pasted into a few places. The maximum baud rate is 115200[1], and that is the more typical usage. [1] https://www.kernel.org/doc/html/latest/admin-guide/serial-console.html Signed-off-by: John Eckersberg <jeckersb@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects an erroneous baud rate value of 114800 to the standard 115200 across several files. The changes are consistent and correctly address the issue in a Dockerfile, a Rust documentation comment, and a markdown documentation file. I have one suggestion to improve maintainability in the Dockerfile by using a variable for the baud rate. Otherwise, the fix is straightforward and correct.
cgwalters
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude pointed this out while I was working on something else
completely unrelated. But it looks like somewhere along the way
114800 snuck its way in and probably got copy/pasted into a few
places. The maximum baud rate is 115200[1], and that is the more
typical usage.
[1] https://www.kernel.org/doc/html/latest/admin-guide/serial-console.html
Signed-off-by: John Eckersberg jeckersb@redhat.com