Elaborate more on Justfile vs Makefile vs GHA#1719
Merged
gursewak1997 merged 1 commit intobootc-dev:mainfrom Oct 31, 2025
Merged
Elaborate more on Justfile vs Makefile vs GHA#1719gursewak1997 merged 1 commit intobootc-dev:mainfrom
gursewak1997 merged 1 commit intobootc-dev:mainfrom
Conversation
Since I'd like to standardize this more. Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the documentation within the Justfile and Makefile to clarify their respective roles and how they interact with each other and with GitHub Actions. The added comments provide valuable context for developers, explaining that the Makefile is intended for local, side-effect-free build tasks, while the Justfile orchestrates higher-level operations like container builds and integration tests that may involve virtualization. The changes are clear, accurate, and significantly improve the project's developer experience by making the build system easier to understand. The changes are well-executed and I have no further suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I'd like to standardize this more.