test: Fix OSCI gating failure#1730
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Nov 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix an OSCI gating failure by adapting the test environment setup for different CI systems and making the reboot process more robust. The changes in hack/Containerfile.packit and hack/provision-packit.sh correctly handle different locations for tmt scripts. The addition of timeouts in hack/packit-reboot.yml is a good improvement for CI stability. My review includes a few suggestions to clean up debugging commands left in the scripts and a minor shell scripting improvement.
Comment on lines
25
to
31
| if [[ -d /var/lib/tmt/scripts ]]; then | ||
| cp -r /var/lib/tmt/scripts "$BOOTC_TEMPDIR" | ||
| ls -al "${BOOTC_TEMPDIR}/scripts" | ||
| else | ||
| cp -r /usr/local/bin "$BOOTC_TEMPDIR" | ||
| ls -al "${BOOTC_TEMPDIR}/bin" | ||
| fi |
Contributor
There was a problem hiding this comment.
The ls -al commands on lines 27 and 30 seem to be for debugging. It's best to remove them to keep the script and its output clean.
Suggested change
| if [[ -d /var/lib/tmt/scripts ]]; then | |
| cp -r /var/lib/tmt/scripts "$BOOTC_TEMPDIR" | |
| ls -al "${BOOTC_TEMPDIR}/scripts" | |
| else | |
| cp -r /usr/local/bin "$BOOTC_TEMPDIR" | |
| ls -al "${BOOTC_TEMPDIR}/bin" | |
| fi | |
| if [[ -d /var/lib/tmt/scripts ]]; then | |
| cp -r /var/lib/tmt/scripts "$BOOTC_TEMPDIR" | |
| else | |
| cp -r /usr/local/bin "$BOOTC_TEMPDIR" | |
| fi |
|
|
||
| # Let's check things in hack folder | ||
| ls -al "$BOOTC_TEMPDIR" "${BOOTC_TEMPDIR}/bin" | ||
| ls -al "$BOOTC_TEMPDIR" |
Contributor
Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
c31f58d to
e26c202
Compare
cgwalters
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed OSCI gating failure.