Conversation
Renovate is currently failing because of the composefs-rs git submodule (trying to debug that) so we're behind. At least this one gets rid of multiple copies of rustix and an old toml version. Signed-off-by: Colin Walters <walters@verbum.org>
2a5f7d3 to
a122882
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the project's dependencies by running cargo update. The main benefit, as noted in the description, is the consolidation of dependencies, particularly rustix and toml, which now resolve to a single version across the workspace. This is a good improvement for maintenance and consistency.
I've reviewed the changes in Cargo.lock. The updates are mostly minor and patch version bumps, which are generally safe. I did notice a few major version bumps for transitive dependencies:
litrsupdated from0.4.2to1.0.0. This is a build-time dependency for documentation generation and is unlikely to cause issues.- The
wasidependency fromgetrandomhas been updated and renamed towasip2. Since this project targets Linux, this change for the WASI target should not have any impact.
Overall, the changes look good and align with the goal of keeping dependencies up-to-date and tidy. Assuming CI passes, this PR is good to merge.
jeckersb
left a comment
There was a problem hiding this comment.
👍
Only thing I see is that we get a new deprecation warning:
warning: use of deprecated unit variant `rustix::thread::Capability::SystemAdmin`: Use CapabilitySet with a single bit instead
--> crates/lib/src/cli.rs:743:83
|
743 | rustix::thread::capability_is_in_bounding_set(rustix::thread::Capability::SystemAdmin)?,
| ^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
warning: `bootc-lib` (lib) generated 1 warning
But that can be fixed in a followup.
➡️ #1750 |
Renovate is currently failing because of the composefs-rs git submodule (trying to debug that) so we're behind. At least this one gets rid of multiple copies of rustix and an old toml version.