Add '--remove-destination' option to cp command#1764
Merged
gursewak1997 merged 1 commit intobootc-dev:mainfrom Nov 14, 2025
Merged
Add '--remove-destination' option to cp command#1764gursewak1997 merged 1 commit intobootc-dev:mainfrom
gursewak1997 merged 1 commit intobootc-dev:mainfrom
Conversation
Signed-off-by: Ben Pilgrim <ben@pilgrim.me.uk>
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the --remove-destination flag to a cp command within the copy_etc_to_state function. The goal is likely to make the copy operation more robust by ensuring destination files are removed before copying. While this is a good intention, my review highlights a potential portability issue. The --remove-destination flag is specific to GNU coreutils' cp and is not universally available, for instance in busybox. This could lead to failures if the code runs in a minimal environment. I've suggested that a more robust, long-term solution would be to replace the external command with a native Rust implementation for file copying, which would also resolve an existing TODO in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1762