docs: Add a packaging-and-integration guide#1782
Conversation
Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'Packaging and Integration' guide, which is a helpful addition for anyone looking to package bootc. The document is comprehensive, covering build requirements, installation, and source packaging. My review identifies one point of inaccuracy regarding the make install target's capabilities, specifically concerning the Dracut module installation. I've provided a comment to correct this and to suggest documenting the appropriate targets for initramfs integration.
| - Man pages to `$(prefix)/share/man/man{5,8}` | ||
| - systemd units to `$(prefix)/lib/systemd/system` | ||
| - Documentation and examples to `$(prefix)/share/doc/bootc` | ||
| - Dracut module to `/usr/lib/dracut/modules.d/51bootc` |
There was a problem hiding this comment.
The documentation states that make install handles the installation of the Dracut module. However, reviewing the Makefile, the install target does not perform this action. The Dracut module is installed by the make install-initramfs-dracut target, which is not part of the default install process.
This inaccuracy could mislead packagers. This line should be removed from the list of actions performed by make install.
For completeness, I recommend adding a new section to this guide that documents the install-initramfs and install-initramfs-dracut targets.
There was a problem hiding this comment.
Impressive! I split this out of #1775 where I am doing that though.
2 participants
No description provided.