Fix undefined BOOTC_buildroot_base in build-sealed script#1815
Merged
cgwalters merged 2 commits intobootc-dev:mainfrom Dec 1, 2025
Merged
Fix undefined BOOTC_buildroot_base in build-sealed script#1815cgwalters merged 2 commits intobootc-dev:mainfrom
cgwalters merged 2 commits intobootc-dev:mainfrom
Conversation
The build-sealed script introduced in PR bootc-dev#1810 referenced BOOTC_buildroot_base which is only defined in GitHub Actions CI, causing failures when running 'just build-sealed' manually. This allows manual execution while maintaining CI compatibility. Signed-off-by: Wei Shi <wshi@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where running just build-sealed manually would fail due to an undefined BOOTC_buildroot_base variable. The fix involves defining this variable in the Justfile with a default value and passing it to the build-sealed script. The script is also updated to accept this new argument and use it. The changes are correct and address the issue. I have one suggestion to improve maintainability by removing a duplicated default value.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Wei Shi <wshi@redhat.com>
ckyrouac
approved these changes
Dec 1, 2025
cgwalters
approved these changes
Dec 1, 2025
| # composefs-sealeduki-sdboot: A system with a sealed composefs using systemd-boot | ||
| variant := env("BOOTC_variant", "ostree") | ||
| base := env("BOOTC_base", "quay.io/centos-bootc/centos-bootc:stream10") | ||
| buildroot_base := env("BOOTC_buildroot_base", "quay.io/centos/centos:stream10") |
Collaborator
There was a problem hiding this comment.
I think this is a correct fix, but it is a bit of an ergonomic problem to have two bases and it'd probably simplify things to just reuse base for this by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build-sealed script introduced in PR #1810 referenced BOOTC_buildroot_base which is only defined in GitHub Actions CI, causing failures when running 'just build-sealed' manually.
This allows manual execution while maintaining CI compatibility.