composefs/usroverlay: Get mode from underlying /usr#1845
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Dec 11, 2025
Merged
composefs/usroverlay: Get mode from underlying /usr#1845cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
We'd want to do this as the permissions for /usr might be different on different distros Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the composefs_usr_overlay function to dynamically retrieve the file mode from the underlying /usr directory, replacing a hardcoded value. This is a good improvement as it ensures the overlayfs for /usr is created with the correct permissions, which can vary between different Linux distributions. The implementation is correct, clear, and uses appropriate error handling. I have no further suggestions.
cgwalters
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd want to do this as the permissions for /usr might be different on different distros