cli: use file extension for host spec to be edited#1866
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Dec 18, 2025
Merged
cli: use file extension for host spec to be edited#1866cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the bootc edit command by adding a .yaml suffix to the temporary file created for interactive editing. This is a great user experience enhancement as it enables syntax highlighting in most editors. The change itself is correct and well-implemented. I have added one comment on a potential issue in the surrounding code that may need attention.
cgwalters
approved these changes
Dec 17, 2025
Collaborator
|
Failure has been fixed by PR #1867. This PR needs a rebase. Thanks. |
Signed-off-by: Pascal Bachor <bachorp@users.noreply.github.com>
auto-merge was automatically disabled
December 18, 2025 16:24
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plays well with editors' language detection (for syntax highlighting).